[wp-trac] [WordPress Trac] #34350: Update Backbone to 1.2.3 and Underscore to 1.8.3

[WordPress Trac]

#34350: Update Backbone to 1.2.3 and Underscore to 1.8.3
--------------------------------------------+------------------------------
 Reporter:  caseypatrickdriscoll            |       Owner:  adamsilverstein
     Type:  enhancement                     |      Status:  reopened
 Priority:  normal                          |   Milestone:  4.5
Component:  External Libraries              |     Version:  4.4
 Severity:  normal                          |  Resolution:
 Keywords:  needs-testing has-patch commit  |     Focuses:  javascript
--------------------------------------------+------------------------------

Comment (by adamsilverstein):

 [attachment:34350.10.diff]
 * Fixes search results on themes
 * Correct several incorrect uses of _.union (also searched codebase for
 other uses, there were none); added a note to the blog post as well.
 (Since Underscore 1.7.0 "For consistency, _.union and _.difference now
 only work with arrays and not variadic args.")
 * Use a namespaced event `themes:update` vs `update`. Backbone 1.2 Added a
 built in `update` event that triggers after any amount of models are added
 or removed from a collection. This additional unexpected event was
 breaking the search results display on themes.php, switching to a
 namespaced event corrects the issue.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34350#comment:55>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform