[wp-trac] [WordPress Trac] #34350: Update Backbone to 1.2.3 and Underscore to 1.8.3
WordPress Trac
noreply at wordpress.org
Thu Feb 18 14:27:14 UTC 2016
#34350: Update Backbone to 1.2.3 and Underscore to 1.8.3
--------------------------------------------+------------------------------
Reporter: caseypatrickdriscoll | Owner: adamsilverstein
Type: enhancement | Status: reopened
Priority: normal | Milestone: 4.5
Component: External Libraries | Version: 4.4
Severity: normal | Resolution:
Keywords: needs-testing has-patch commit | Focuses: javascript
--------------------------------------------+------------------------------
Comment (by adamsilverstein):
Replying to [comment:50 imath]:
> 34350.10.patch is bringing back the buttons and it's possible to bulk
delete, but the 'Delete Selected' doesn't come back to its initial state
when the selection is emptied. I hope this "half way" patch will help you
fix this completely.
Great. Thanks for catching these.
In your patch, I don't think you need the third 'context' variable
(`this`), unless the call you are replacing has the `_.bind( function,
this )` format the function doesn't need `this` bound and doing so adds
overhead and could possibly lead to unexpected behavior (if the function
expected `this` to have a different context).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34350#comment:52>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list