[wp-trac] [WordPress Trac] #34755: "(Currently set to: %s)" string should use the location name instead of slug
WordPress Trac
noreply at wordpress.org
Mon Feb 15 19:11:04 UTC 2016
#34755: "(Currently set to: %s)" string should use the location name instead of
slug
----------------------------+---------------------------
Reporter: SergeyBiryukov | Owner: ryankienstra
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.5
Component: Customize | Version: 4.3
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
----------------------------+---------------------------
Comment (by ryankienstra):
'''New Patch That Fixes JUnit Test'''
@westonruter,
Please see this
[https://core.trac.wordpress.org/attachment/ticket/34755/a9e1d83.diff
patch], which has passing JUnit tests. The [https://github.com/xwp
/wordpress-develop/pull/141 pull request]'s [https://travis-ci.org/xwp
/wordpress-develop/builds/109413401 Travis build] now passes.
As you [https://core.trac.wordpress.org/ticket/34755#trac-
change-2-1455513221285388 suggested], I fixed the failing JUnit test by
adding the object `locationSlugMappedToName` to
[https://core.trac.wordpress.org/browser/trunk/tests/qunit/fixtures
/customize-menus.js fixtures/customize-menus.js].
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34755#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list