[wp-trac] [WordPress Trac] #33755: Add Site Logo to WordPress Core

[WordPress Trac]

#33755: Add Site Logo to WordPress Core
-------------------------------------------------+-------------------------
 Reporter:  fatmedia                             |       Owner:
     Type:  feature request                      |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.5
Component:  Customize                            |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  ux-feedback has-patch needs-testing  |     Focuses:  ui
  needs-unit-tests has-screenshots               |
-------------------------------------------------+-------------------------

Comment (by melchoyce):

 > This should be a theme-specific setting. The theme has a better idea of
 what size restrictions there are and can possibly help with positioning.
 Why not let the customizer do it's thing?

 That's exactly what this feature is doing — providing a standardized way
 for themes to offer logo support, exactly like header and background
 images. This UI won't just show up randomly, it will only exist if a theme
 tells it to exist.

 The theme goes:

 "Hey, I want people using my theme to be able to add a logo. I want it to
 be positioned here and have this kind of sizing."

 WordPress goes:

 "Cool! I'll add a UI for you in the Customizer."

 Boom, logo.

 > Can't a theme add a site logo image form of some sort?

 No, not yet — not without writing something custom. That's why there are
 dozens of ad-hoc logo implementations, which is awful for standardization
 across themes. If you change your theme, you lose your logo. If we add a
 feature that creates logo support, you don't lose your logo if you change
 to another theme that supports logo.

 > What problem is this solving?

 There are dozens of ad-hoc ways for themes to add logo support. It lacks
 standardization and makes it confusing for users. It sucks for theme
 developers, because they have to roll their own. It sucks for theme
 compatibility.

 > Who is this for?

 Theme developers and businesses large and small, nonprofits, magazine,
 anyone who needs a logo or is already using a logo and might one day also
 change their theme or migrate their content to a new site. This is a huge
 number of users.

 > Does this solution need to be global? (stays set no matter which theme
 is active regardless of theme support)

 No, that's not what this is doing. This was never going to be global. This
 is not a global setting, it's an `add_theme_support()`.

 I'm honestly shocked this has been so controversial. In all seriousness,
 have y'all used premade themes, rather than rolling your own? There is a
 distinct lack of standardization for this kind of feature and it makes
 live harder for everyone. This is a great step forward to making the lives
 of both theme developers and theme users easier.

 As to making it a feature plugin, it ''has'' been tested in a plugin —
 Jetpack. It's been a Jetpack feature since 2014. Maybe we could ask
 Jetpack support what their experience with this feature has been and how
 often people have questions about using it?Someone could also try to see
 how many themes are already using it by searching for the
 `add_theme_support` call in the .org theme directory.

 Also, the biggest argument seems to be "it'll conflict with Site Icon and
 that's confusing" — but I don't think that's the fault of Logos, but of
 ''Icons'', which are confusing, have a confusing UI in the Customizer, and
 they forego industry standard terminology (favicons) so people can't even
 Google to figure out what the feature is. Rather than derailing Logos,
 maybe we should be thinking about making Site Icons more distinct.

 > I wouldn’t be surprised if most sites featuring both a logo and a
 favicon had a different design for each of them.

 I agree with this. Most logos also make terrible favicons, since they
 usually contain text. A favicon should just be a logo mark.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33755#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform