[wp-trac] [WordPress Trac] #34755: "(Currently set to: %s)" string should use the location name instead of slug

WordPress Trac noreply at wordpress.org
Mon Feb 15 04:07:33 UTC 2016


#34755: "(Currently set to: %s)" string should use the location name instead of
slug
----------------------------+-----------------------------
 Reporter:  SergeyBiryukov  |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Future Release
Component:  Customize       |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------------
Changes (by ryankienstra):

 * keywords:  needs-patch => has-patch


Comment:

 '''Patch For Defect'''
 ''Requesting Review''

 @SergeyBiryukov,
 Attached is a
 [https://core.trac.wordpress.org/attachment/ticket/34755/34755.diff
 patch], and an identical [https://github.com/xwp/wordpress-
 develop/pull/141 GitHub PR] for this defect.

 This changes the "Menu Location" string in Customizer menu controls to the
 location name. Before, this string was the location slug.

 So this adds an object to the data passed to the Customizer :
 `locationSlugMappedToName`. And uses this to retrieve the location name.

 This also changes the argument name from `themeLocations` to
 `themeLocationSlugs`. This doesn't change the argument, it only clarifies
 the fact that it consists of slugs.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34755#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list