[wp-trac] [WordPress Trac] #33305: Plugin details modal: initial focus and constraining tabbing
WordPress Trac
noreply at wordpress.org
Fri Feb 12 18:16:03 UTC 2016
#33305: Plugin details modal: initial focus and constraining tabbing
--------------------------+--------------------------------------------
Reporter: afercia | Owner: afercia
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.5
Component: Plugins | Version: 4.2
Severity: normal | Resolution:
Keywords: has-patch | Focuses: ui, accessibility, javascript
--------------------------+--------------------------------------------
Comment (by afercia):
Refreshed patch with some cleaning and (hopefully) some improvements.
Removed some JavaScript that seems no more useful, was used to set the
color and the text on the old modal "title bar" see screenshot:
[[Image(https://cldup.com/pIbnUI4nsw.png)]]
The iframe title gets the name from the link `data-title` attribute but
not all the links that open the plugin modal have this attribute, see
below (same thing happens in the Import screen, in the Dashboard, etc.):
[[Image(https://cldup.com/Bb4I_bZCyL.png)]]
Thus, when clicking on a link without the `data-title` attribute, a string
`undefined` is injected in the HTML:
[[Image(https://cldup.com/_8vsmMOLHw.png)]]
The refactored JavaScript covers this case now, maybe worth considering to
audit all the links that open the plugin modal and add the missing
attribute. Should go in a separate ticket though.
Note about IE 8: to properly set focus back when closing the modal, it
would need a `setTimout()` but honestly I'd prefer to don't add it just to
support an outdated browser.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33305#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list