[wp-trac] [WordPress Trac] #33755: Add Site Logo to WordPress Core

[WordPress Trac]

#33755: Add Site Logo to WordPress Core
-------------------------------------------------+-------------------------
 Reporter:  fatmedia                             |       Owner:
     Type:  feature request                      |      Status:  reopened
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Customize                            |  Review
 Severity:  normal                               |     Version:
 Keywords:  ux-feedback has-patch needs-testing  |  Resolution:
                                                 |     Focuses:  ui
-------------------------------------------------+-------------------------
Changes (by mikeschroder):

 * keywords:  needs-patch ux-feedback => ux-feedback has-patch needs-testing


Comment:

 Thanks for the patch, @obenland!

 I chatted with him about this a bit, and he notes:
 - This needs unit tests and docs
 - Has a workaround for `header_text` option for themes that support logos
 but don’t support custom headers. Jetpack uses its own option for this,
 but we'd ideally want to do this differently for core.

 It will also (as noted previously in the ticket) need at least a round of
 user tests.

 In my testing of [attachment:33755.diff], noticed the following:
 - It's very hard to test, since it needs a theme that both supports site
 logos, and is using `the_site_logo()` rather than
 `jetpack_the_site_logo()`.  @karmatosed is checking into what it would
 take to have a twentysixteen to test.
 - I'd put "logo" above "site icon", since once a site icon is inserted, at
 least at mid-height resolutions, "logo" gets hidden entirely because icons
 are always a square aspect ratio.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33755#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform