[wp-trac] [WordPress Trac] #35797: delete_metadata should only delete metadata cache entries with the value specified in $meta_value arg

WordPress Trac noreply at wordpress.org
Thu Feb 11 12:16:32 UTC 2016


#35797: delete_metadata should only delete metadata cache entries with the value
specified in $meta_value arg
--------------------------------+------------------------------------------
 Reporter:  rahal.aboulfeth     |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Options, Meta APIs  |     Version:  trunk
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  administration, performance
--------------------------------+------------------------------------------
Changes (by Clorith):

 * keywords:   => has-patch


Comment:

 I'm not sure your patch applies here, as it fires on the conditional that
 you've supplied `delete_metadata` with the $delete_all as true, and you
 are then meant to delete all entries with that key regardless of the
 meta_value.

 I suspect it would probably make more sense to look into the logic of
 `wp_delete_attachment` here

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35797#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list