[wp-trac] [WordPress Trac] #34359: Cache output of `wp_upload_dir()` to improve performance

[WordPress Trac]

#34359: Cache output of `wp_upload_dir()` to improve performance
-------------------------------------------+-------------------------------
 Reporter:  mikeschroder                   |       Owner:  mikeschroder
     Type:  defect (bug)                   |      Status:  assigned
 Priority:  normal                         |   Milestone:  4.5
Component:  Media                          |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  needs-testing has-patch early  |     Focuses:  multisite,
                                           |  performance
-------------------------------------------+-------------------------------

Comment (by mikeschroder):

 Ran tests on a box with Memcached with [attachment:34359.4.patch]; didn't
 notice issues.

 However, have this failing unit test:
 {{{
 Tests_Post_Attachments::test_wp_get_attachment_url_should_force_https_when_administering_over_https_and_siteurl_is_https
 Failed asserting that two strings are identical.
 --- Expected
 +++ Actual
 @@ @@
 -https://example.org/wp-content/uploads/2016/02/test-image-1.jpg
 +http://example.org/wp-content/uploads/2016/02/test-image-1.jpg

 /vagrant/www/wordpress-
 develop/tests/phpunit/tests/post/attachments.php:467
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34359#comment:42>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform