[wp-trac] [WordPress Trac] #35770: Shortcode fails with 4.4. It is working with 4.3

[WordPress Trac]

#35770: Shortcode fails with 4.4. It is working with 4.3
-------------------------------+------------------------------
 Reporter:  dezio1900          |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Shortcodes         |     Version:  4.4.1
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+------------------------------

Comment (by dezio1900):

 I tried the mu-plugin, and shortcode works in admin area, as part of admin
 notice output.

 But it appears that issue is somewhere in filters applied to the_content.

 This is the content of the page I am using, which fails (text version) :


 {{{
 [content]

 Safety is Glacier Raft Company’s number one priority. No exceptions, no
 question, no ifs, ands or buts about it. Keeping you and your family safe
 is our primary goal, and the decisions we make each and everyday are based
 on the importance of keeping this true.

 Prioritizing safety doesn’t mean adventure is compromised. It means you
 can have the best possible day of white water rafting because you never
 have to question if safety is as important to us as it is to you.

 [content_with_image image_position="left" image_id="198"
 content_margin_top="0" title="EXPERIENCED GUIDES"
 allow_content_below_image="no"]

 All of our trips are led by professionals who have years of experience
 working as whitewater raft guides on the Kicking Horse River. They have
 rafted 100s (if not 1000s of trips), and their goal is to have a safe,
 clean run everyday.

 They each have a valid British Columbia River Outfitters Association Guide
 Licence, Swift Water Rescue Technician Certificate, and Wilderness First
 Aid Certificate.

 [/content_with_image]

 [content_with_image image_position="right" image_id="1137"
 content_margin_top="0" title="CHECKING WATER LEVELS"
 allow_content_below_image="no"]

 We check water levels every morning, and we have strict guidelines and
 cutoffs that dictate our course for the day. If water levels are above a
 specific cutoff point, we will not raft certain sections.

 This happens commonly in June on the Kicking Horse River when the water is
 too high for us to run the lower canyon. This doesn’t mean you’re going to
 experience any less of an adventure, however. High water brings the
 biggest rapids and biggest hits, and the middle canyon at this time has
 the most whitewater we’ll see at any point throughout the summer.

 [/content_with_image]

 [content_with_image image_position="left" image_id="1138"
 content_margin_top="0" title="INTRO TALKS AND SAFETY BRIEFINGS"
 allow_content_below_image="no"]

 Our guides go through very thorough intro talks and safety briefings
 before you get anywhere near the water. They’ll go over how to get ready,
 what to expect, and what to do in the event something does happen. While
 flips and swims are rare, they do occur, and we want you to be as prepared
 as possible just in case.

 Our guides provide clear instructions and demonstrations, and they have
 you practice various commands before you get into any whitewater.  Once
 you’re in the raft everyone is working together as a team, and your guide
 will provide you with the skills and knowledge required to achieve this.

 [/content_with_image]

 [content_with_image image_position="right" image_id="1139"
 content_margin_top="0" title="MINIMUM AGE REQUIREMENTS"
 allow_content_below_image="no"]

 Our minimum age, height and weight restrictions were also established with
 safety in mind.

 Who has to stay and who gets to go is always left up to the discretion of
 our guides.  We know it can be tough when the whole family can’t continue
 on together, but the guides’ decisions are always made with your best
 interest at heart.  If they don’t feel it’s safe for someone to carry on
 it’s for a very good reason.

 [/content_with_image]

 [/content]

 [testimonial bg_image_id="1340" signature="MichelleHughson, TripAdvisor"
 bg_color="0,0,0,0.3"]
 <blockquote>Glacier's main focus was safety by far. They were very clear
 and explicit about all aspects of safety but made sure that everyone felt
 comfortable to ensure a great time. It was my first time white water
 rafting and no part of it made me nervous after all the instructions were
 given.</blockquote>
 [/testimonial]
 [content]
 As required by all adventure activity providers, each guest of Glacier
 Raft Company will be required to read and sign a Release of Liability,
 Waiver of Claims and Assumption of Risks and Indemnity Agreement prior to
 their rafting trip.<span class="Apple-converted-space">  </span>To view
 this document, please <a title="Waiver" href="http://glacierraft.com/wp-
 content/uploads/2015/03/Waiver-GRC-GRA-2014-update-Vers.16-incl.-e-m-cnst-
 legal-size-final.pdf" target="_blank">click here.</a>
 [/content]
 }}}

 All other shortcodes works, but "content_with_image" one fail, even when I
 have simple return string in shortcode PHP source.

 As soon as I overwrite /wp-includes/shortcodes.php file with one from
 v4.3, it works. I also tried using default WP theme ( Twenty Fifteen -
 v1.4 ) and with all plugins disabled - same issue.

 And when I manually write something like this:

 {{{
 [content_with_image image_id="100"]

 Test...

 [/content_with image]
 }}}

 Then it works.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/35770#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform