[wp-trac] [WordPress Trac] #31195: Add a user-friendly way to preview site responsiveness in the Customizer
WordPress Trac
noreply at wordpress.org
Mon Feb 1 22:43:37 UTC 2016
#31195: Add a user-friendly way to preview site responsiveness in the Customizer
-------------------------------------+-------------------------------------
Reporter: celloexpressions | Owner: celloexpressions
Type: feature request | Status: assigned
Priority: normal | Milestone: 4.5
Component: Customize | Version:
Severity: normal | Resolution:
Keywords: has-screenshots has- | Focuses: ui, accessibility,
patch needs-docs | administration
-------------------------------------+-------------------------------------
Changes (by DrewAPicture):
* keywords: has-screenshots has-patch => has-screenshots has-patch needs-
docs
Comment:
PHP docs feedback on [attachment:31195.3.diff]:
'''`get_previewable_devices()` method:
* The DocBlock summary should use a third-person singular verb. A trick
for getting this right is imagining how the information would be read in
the context of the developer reference. Instead of "Get previewable
devices.", should be something like "Retrieves a list of preview-able
devices."
* The declaration should have a `public` access modifier, and the DocBlock
should contain an `@access public` tag
* Needs an `@return` tag, type, and description ending in a period
* The `customize_previewable_devices` filter needs an accompanying hook
doc
Separately, we should probably escape `$device` in the `data-device` data
attribute in wp-admin/customize.php
--
Ticket URL: <https://core.trac.wordpress.org/ticket/31195#comment:77>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list