[wp-trac] [WordPress Trac] #39223: Add a filter to edit $meta array in wpmu_signup_user

[WordPress Trac]

#39223: Add a filter to edit $meta array in wpmu_signup_user
-------------------------+------------------------
 Reporter:  Mista-Flo    |       Owner:  Mista-Flo
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  4.8
Component:  Users        |     Version:  3.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  multisite
-------------------------+------------------------
Changes (by flixos90):

 * owner:   => Mista-Flo
 * status:  new => assigned
 * milestone:  Awaiting Review => 4.8


Comment:

 This looks like a useful enhancement to me as well.

 The patch looks good except for a few documentation issues:
 * The filter description should be in 3rd person singular.
 * The filter description should describe what is being filtered and thus
 should start with "Filters ...", for example "Filters the metadata for a
 user signup.".
 * The description for the `$meta` parameter should rather say "Default
 empty array." instead of a full sentence in the end.
 * The description for the `$key` parameter is missing a dot.
 * Since the data is serialized, an additional line could possibly included
 as extended description to indicate this to developers, maybe something
 like "The metadata will be serialized prior to storing it in the
 database.".

 All kind of nitpicking, but would you update the patch @Mista-Flo? :)

 The last thing we might think about is whether `signup_user_meta` is the
 best name for the filter. I'm not opposed to it, but just to throw
 something in the room, `user_signup_meta` or `wpmu_signup_user_meta` (the
 latter would give parity with the function although I don't like the wpmu
 prefix) would be alternatives. What do you think?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39223#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform