[wp-trac] [WordPress Trac] #39380: wp_update_comment can cause database error with new filter

WordPress Trac noreply at wordpress.org
Tue Dec 27 16:28:15 UTC 2016


#39380: wp_update_comment can cause database error with new filter
-------------------------+------------------
 Reporter:  dshanske     |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.8
Component:  Comments     |     Version:  4.6
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------
Changes (by rachelbaker):

 * type:  defect (bug) => enhancement
 * milestone:  4.7.1 => 4.8


Comment:

 @dshanske Prior to [38674] the sliced data was passed to the database
 update statement and then the `edit_comment` action, this doesn't look
 like a regression to me. Am I missing something?

 I understand that you are approaching this with a specific use-case in
 mind (updating meta). However, I am not convinced other folks would expect
 the `$data` parameter in the `edit_comment` action to differ from the
 specific keys/values used to update the comment table.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39380#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list