[wp-trac] [WordPress Trac] #39367: Don't no-op $user_id in test suite's wp_set_auth_cookie()

WordPress Trac noreply at wordpress.org
Sat Dec 24 01:39:07 UTC 2016


#39367: Don't no-op $user_id in test suite's wp_set_auth_cookie()
------------------------------+------------------
 Reporter:  danielbachhuber   |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.8
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  needs-patch       |     Focuses:
------------------------------+------------------

Comment (by jnylen0):

 Replying to [comment:4 johnbillion]:
 > Overriding this function in the test suite is asking for trouble.

 What kind of trouble would you expect to see?

 > The pluggable function should be refactored to make it testable.

 I think this could be done later, and the simple patch here is probably
 fine for this ticket - the function is already being overridden in trunk
 and 4.7.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39367#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list