[wp-trac] [WordPress Trac] #38559: Current header image gets clipped in the Customizer

[WordPress Trac]

#38559: Current header image gets clipped in the Customizer
--------------------------+-----------------------------
 Reporter:  bradyvercher  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Customize     |     Version:  3.9
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------------

Comment (by celloexpressions):

 Replying to [comment:2 westonruter]:
 > @bradyvercher Should not the header image control be taken further to
 extend the `MediaControl` instead of `Control`? It seems that there is
 some logic in here that is redundant. All that should be needed is the
 header image attachment ID and the attachment data (and image size URLs)
 should be fetched when the control is embedded, like in #36521.
 >
 > I don't see why we need both the `header_image` and the
 `header_image_data` setting.

 The header image control needs to be totally refactored to make use of the
 media control hierarchy, JS-templated controls, and even the customizer JS
 API, since it was introduced before any of those existed. See #36581.

 Realistically, I think it would be best to prioritize that larger
 refactoring over all of these individual bugs for the header image
 control, as many would be fixed in the process. All of the media controls
 will benefit, with things like #32861 being fixed in the process. If
 anyone is interested in taking on that project I'd be happy to assist with
 any questions on the implementation.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38559#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform