[wp-trac] [WordPress Trac] #39327: Database connection errors in unit tests on 4.7

[WordPress Trac]

#39327: Database connection errors in unit tests on 4.7
------------------------------------------+---------------------
 Reporter:  rmccue                        |       Owner:  pento
     Type:  defect (bug)                  |      Status:  closed
 Priority:  normal                        |   Milestone:  4.7.1
Component:  Build/Test Tools              |     Version:  4.7
 Severity:  normal                        |  Resolution:  fixed
 Keywords:  has-patch commit fixed-major  |     Focuses:
------------------------------------------+---------------------
Changes (by pento):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"39627"]:
 {{{
 #!CommitTicketReference repository="" revision="39627"
 Tests: Restore the database connection earlier when switching test groups.

 When plugins don't disable the `backupGlobals` PHPUnit option in their own
 tests, `$wpdb` is backed up and restored between classes of tests. The
 serialisation process used for this broke the database connection. This
 previously wasn't a problem, as it was reconnecting before each test.

 [38398] introduced some changes that required the connection to be
 available in `setUpBeforeClass()`, earlier than in was previously
 reconnecting. This didn't cause warnings in Core, but it did cause
 warnings for plugins that don't disable the `backupGlobals` option.

 The database connection now reconnects in `setUpBeforeClass()`. This
 change also fixes a few Core tests that weren't calling
 `parent::setUpBeforeClass()` or `parent::tearDown()` correctly.

 Merges [39626] to the 4.7 branch.

 Fixes #39327.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39327#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform