[wp-trac] [WordPress Trac] #29204: SimplePie error with fetch_feed()

[WordPress Trac]

#29204: SimplePie error with fetch_feed()
-----------------------------------------------+---------------------------
 Reporter:  useStrict                          |       Owner:
     Type:  defect (bug)                       |  SergeyBiryukov
 Priority:  normal                             |      Status:  reviewing
Component:  Feeds                              |   Milestone:  Awaiting
 Severity:  normal                             |  Review
 Keywords:  has-patch 4.7-early needs-refresh  |     Version:  3.8
                                               |  Resolution:
                                               |     Focuses:
-----------------------------------------------+---------------------------

Comment (by thefarlilacfield):

 I'm writing to confirm that `29204.diff` fixes this.

 For the sake of reference (search results) it's worth noting a few things.

 This change removes WP_Feed_Cache as a dependency of the WordPress core.

 The `set_cache_class()` method that is being removed by the patch had
 already been depreciated as of the 2012 version of SimplePie (1.3.1)
 relied upon by WordPress (up to 4.7 at least).

 My look at the code has been cursory, but it appears that WordPress is
 relying upon legacy features of the library that inherently require a
 dynamic method to be called as static.  As of PHP 5 this has merited an an
 `E_STRICT` warning.  PHP 7 escalates this to an `E_DEPRECATED` warning,
 and the current documentation notes that support may be removed in the
 future.

 It also appears that the maintainers of SimplePie have specifically
 assumed the legacy burden of WordPress support all the way up to version
 1.4.3, maintaining backwards compatibility
 [https://github.com/simplepie/simplepie/issues/443#issuecomment-222282500
 ""unless there's a really good reason not to""]
 ([https://github.com/mblaney mblaney] being is the current maintainer),
 and that this consideration has overshadowed discussion of a 2.0.0
 revision of their library.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29204#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform