[wp-trac] [WordPress Trac] #39311: New user activation welcome page links to the wrong site

[WordPress Trac]

#39311: New user activation welcome page links to the wrong site
-------------------------------------+------------------------------
 Reporter:  tmoore41                 |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Login and Registration   |     Version:  4.7
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  multisite
-------------------------------------+------------------------------

Comment (by Ipstenu):

 I mentioned this in slack as the issue comes up a lot in this ticket -
 There is no such thing as a "network URL" or "Network Site"

 There's a Network '''admin''' and a Main/Primary site, but the 'network
 site' doesn't exist. It makes it harder to debug when you call the Main
 Site the network site. And this is not anyone's fault: WP for a long time
 had the main site be the network administration. We don't anymore, and
 it's very important we're clear on where someone is being redirected to,
 as those are very different behaviors.

 I know I sound pedantic and nit-picky but when reporting bugs, it's really
 important to use the proper terms once you know them. It helps make sure
 we're all talking about the same thing.

 So to reiterate what's going on:

 1. Go to a subsite (ex domain.com/subsite/ or sub.domain.com)
 2. Create the user with email confirmation.
 3. User gets the activation link

 The URL at that point is ''not'' the expected subsite URL (ex
 domain.com/subsite/wp-activate.php or sub.domain.com/wp-activate.php)

 Instead it is domain.com/wp-activate.php

 I did this:

 I went to my subsite (domain.com/test) and added a new user

 > Hi,
 > You've been invited to join 'test' at
 > http://domain.com/test with the role of Subscriber.
 > If you do not want to join this site please ignore
 > this email. This invitation will expire in a few days.
 >
 > Please click the following link to activate your user account:
 > http://domain.com/test/wp-activate.php?key=KEYHERE

 That's exactly what I expect to see in my email.

 However it's the rederning of the page that's wrong:

 > Your account is now active!
 >
 > Username: USER
 >
 > Password: PASSWORD
 >
 > Your account is now activated. Log in or go back to the homepage.

 The link for login is domain.com/wp-login.php

 Now when I'm added to a site, which is what this ticket claims we're doing
 (go to a subsite to add the user), WordPress ''properly'' redirects me on
 login to domain.com/test/wp-admin (it's supposed to do that)

 So I don't see the problem as indicated. I can see it happening if you
 just add the user to the network at domain.com/wp-admin/network/user-
 new.php but that isn't what was reported.

 > I am using multisite, and I am adding users from within one of the child
 sites, not from the network site.

 When I add users from the child site, the login link being the main site
 is not an issue, as WP redirects on login to 'My' site.

 Question for @tmoore41: Are these NEW users or existing users?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39311#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform