[wp-trac] [WordPress Trac] #39277: get_post_galleries() produces PHP Warning in PHP 7.1 when parsing empty shortcode

[WordPress Trac]

#39277: get_post_galleries() produces PHP Warning in PHP 7.1 when parsing empty
shortcode
------------------------------------------+--------------------
 Reporter:  DJPaul                        |       Owner:
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  4.7.1
Component:  Shortcodes                    |     Version:  4.7
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:
------------------------------------------+--------------------
Changes (by pento):

 * keywords:   => needs-patch needs-unit-tests
 * milestone:  Awaiting Review => 4.7.1


Comment:

 `shortcode_parse_atts()` can return an `array` or a `string`, this isn't
 being tested before treating the return value as an `array`.

 I've audited all other usage of `shortcode_parse_atts()` in Core, nothing
 else suffers from a similar problem. There was one minor documentation
 issue, tracked in #39294.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39277#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform