[wp-trac] [WordPress Trac] #39109: Twenty Seventeen: starter content array needs a filter
WordPress Trac
noreply at wordpress.org
Wed Dec 14 02:27:18 UTC 2016
#39109: Twenty Seventeen: starter content array needs a filter
------------------------------+--------------------
Reporter: celloexpressions | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.7.1
Component: Bundled Theme | Version: 4.7
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
------------------------------+--------------------
Changes (by celloexpressions):
* keywords: needs-patch => has-patch
Comment:
[attachment:39109.1.diff] adds inline documentation to
[attachment:39109.patch] for the new filter and also adds periodic inline
documentation throughout the starter content array to explain what's
happening and some of the decisions the theme makes. This makes Twenty
Seventeen a much better example of how to register starter content as
there is a better explanation of how it's working and what it's doing
inline. The comments here are a first pass - if anyone sees any typos or
possible additions/improvements please iterate on it.
Switching to has-patch since [attachment:39109.1.diff] covers everything
that would be needed for child themes, especially if other themes base
their implementations on Twenty Seventeen (1.1+). Plugins would probably
be more comfortable with filtering the expanded array via the existing
core filter mentioned above than themes, but adding another filter in core
pre-expansion would be the other potential change here.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39109#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list