[wp-trac] [WordPress Trac] #39220: Remove 1 `is_super_admin()` check in wp-admin/user-new.php (was: Remove 1 check in wp-admin/user-new.php)

[WordPress Trac]

#39220: Remove 1 `is_super_admin()` check in wp-admin/user-new.php
-----------------------------+------------------------
 Reporter:  supercoder       |       Owner:  flixos90
     Type:  enhancement      |      Status:  reviewing
 Priority:  normal           |   Milestone:  4.8
Component:  Role/Capability  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:  multisite
-----------------------------+------------------------
Changes (by flixos90):

 * status:  new => reviewing
 * focuses:   => multisite
 * owner:   => flixos90
 * milestone:  Awaiting Review => 4.8
 * keywords:  has-patch => needs-patch


Comment:

 Hi @supercoder, and thanks for the ticket and patch! :)

 Can you maybe have another look at the patch and review "Ticket 11" on
 https://core.trac.wordpress.org/ticket/37616#comment:26 in detail? In your
 patch you removed the `$username != null` check, but instead the
 `!is_super_admin( $user_id )` check should be removed. You could also
 adjust the spacing in `( array_key_exists($blog_id,
 get_blogs_of_user($user_id)) )` (same line) to follow the WordPress coding
 standards.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39220#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform