[wp-trac] [WordPress Trac] #32816: No or inadequate Custom Link URL validation

WordPress Trac noreply at wordpress.org
Mon Dec 12 07:16:37 UTC 2016


#32816: No or inadequate Custom Link URL validation
-------------------------------------------------+-------------------------
 Reporter:  JanR                                 |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  4.8
Component:  Customize                            |     Version:  4.3
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug needs-testing has-    |     Focuses:  ui,
  patch                                          |  javascript
-------------------------------------------------+-------------------------
Changes (by westonruter):

 * keywords:  good-first-bug needs-testing needs-patch => good-first-bug
     needs-testing has-patch


Comment:

 [attachment:32816.6.diff] adds more unit tests, removes the JS-validation
 since I think we should keep it DRY, and also adds styling to the URL
 field when there is an `invalid_url` error.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32816#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list