[wp-trac] [WordPress Trac] #39195: Undefined index: extension in class-wp-image-editor-imagick.php on line 152
WordPress Trac
noreply at wordpress.org
Mon Dec 12 06:07:45 UTC 2016
#39195: Undefined index: extension in class-wp-image-editor-imagick.php on line 152
----------------------------------------+------------------------
Reporter: JaworskiMatt | Owner: joemcgill
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 4.7.1
Component: Media | Version: 4.7
Severity: normal | Resolution:
Keywords: has-patch needs-unit-tests | Focuses:
----------------------------------------+------------------------
Comment (by chandrapatel):
Replying to [comment:5 joemcgill]:
> Thanks all. [attachment:39195.patch] looks like a straightforward way to
fix this issue. Long-term, I wonder if we would want to do some mime/type
checking here instead of relying only on the existence of a '.pdf'
extension on the file itself? Either way, we can go with this approach for
4.7.1 and consider a mime check as an enhancement.
>
> @chandrapatel would you mind adding a unit test for this bug to make
sure we don't reintroduce it in the future?
Hello @joemcgill
Thanks for your response. I will try to add unit test for this.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39195#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list