[wp-trac] [WordPress Trac] #34870: dbDelta Not Specifying Key Length Duplicate Indexes

[WordPress Trac]

#34870: dbDelta Not Specifying Key Length Duplicate Indexes
-------------------------------------------------+-------------------------
 Reporter:  charlestonsw                         |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.8
Component:  Database                             |     Version:  2.8.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-unit-tests needs-    |     Focuses:
  testing                                        |  performance
-------------------------------------------------+-------------------------
Changes (by pento):

 * keywords:  has-patch needs-unit-tests needs-refresh => has-patch needs-
     unit-tests needs-testing
 * milestone:  Awaiting Review => 4.8


Comment:

 [attachment:34870.2.diff] is a first pass at ignoring the subpart in both
 the SQL and the current table definition, when searching for duplicate
 indexes.

 Could y'all please test this patch and see if it helps with your
 particular situations.

 A couple of notes before commit: needs a deeper review to ensure I haven't
 missed things, or could've written it better. It also probably needs more
 unit tests.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34870#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform