[wp-trac] [WordPress Trac] #39241: Add more unit tests for the custom header feature
WordPress Trac
noreply at wordpress.org
Sun Dec 11 21:28:07 UTC 2016
#39241: Add more unit tests for the custom header feature
--------------------------+------------------------------
Reporter: bradyvercher | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+------------------------------
Changes (by bradyvercher):
* keywords: => has-patch
Comment:
[attachment:39241.diff] contains tests introduced in #38639 and they've at
least [https://core.trac.wordpress.org/ticket/38738#comment:23 had a
cursory review here].
It doesn't look like the patch keeps binary files, so the video file will
need to be [https://github.com/mathiasbynens/small/blob/master/mp4.mp4
downloaded from this repo] and saved to
`tests/phpunit/data/images/video.mp4` to make the tests pass -- I wasn't
sure if a new directory should be created for videos instead. According to
the license, that file should be public domain:
> To the extent possible under law, the author has waived all copyright
and related or neighboring rights to this work.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39241#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list