[wp-trac] [WordPress Trac] #39227: Changeset parameter not generated

WordPress Trac noreply at wordpress.org
Sat Dec 10 23:12:23 UTC 2016


#39227: Changeset parameter not generated
--------------------------+--------------------------
 Reporter:  pavelevap     |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.7.1
Component:  Customize     |     Version:  4.7
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+--------------------------
Changes (by westonruter):

 * keywords:   => needs-patch
 * owner:   => westonruter
 * status:  new => accepted
 * milestone:  Awaiting Review => 4.7.1


Comment:

 The changes get persisted into a changeset currently at the
 `AUTOSAVE_INTERVAL` or whenever you `blur` the `customize.php` window (or
 `beforeunload` it). This is why you see the `changeset_uuid` appear in the
 URL the moment that you click into the preview, because this is a `blur`
 event on the `customize.php` window. This is probably an unintentional
 side effect of the fix done in #39081. This needs to be fixed.

 However, when starting customization with starter content initially
 supplied, I'm not seeing the URL update as expected. I am seeing this
 behavior once `fresh_site` is `0`. Specifically, once you click into the
 URL bar you should see the `changeset_uuid` param supplied, as in
 [attachment:changeset_uuid-param-added-upon-window-blur.mov].

 Nevertheless, we really shouldn't be waiting for the `customize_changeset`
 post to be created before updating the URL with the `changeset_uuid`
 param. The moment that the `saved` state becomes `false` we should at that
 moment make sure that the `changeset_uuid` param is added to the URL.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39227#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list