[wp-trac] [WordPress Trac] #39207: Replace is_super_admin() check with current_user_can( 'manage_options' ) in wp-admin/options-general.php

WordPress Trac noreply at wordpress.org
Fri Dec 9 19:47:38 UTC 2016


#39207: Replace is_super_admin() check with current_user_can( 'manage_options' ) in
wp-admin/options-general.php
--------------------------------+------------------------
 Reporter:  Dhaval Parekh       |       Owner:  flixos90
     Type:  enhancement         |      Status:  reviewing
 Priority:  normal              |   Milestone:  4.8
Component:  Options, Meta APIs  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  needs-patch         |     Focuses:  multisite
--------------------------------+------------------------
Changes (by johnbillion):

 * keywords:  has-patch => needs-patch
 * component:  Role/Capability => Options, Meta APIs


Comment:

 The intention of this line of code is to only show the `WPLANG` warning to
 super admins on a multisite installation. A regular administrator on
 multisite should not see this message, but an administrator on a single
 site installation should.

 I'm not sure which cap would be more appropriate to check for here. Maybe:

 `if ( ! is_multisite() || current_user_can( 'manage_network_options` )`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39207#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list