[wp-trac] [WordPress Trac] #39175: Customizer assumes url is passed with replaceState and pushState

WordPress Trac noreply at wordpress.org
Fri Dec 9 02:01:46 UTC 2016


#39175: Customizer assumes url is passed with replaceState and pushState
-------------------------------------+-------------------------------------
 Reporter:  Christian1012            |       Owner:  westonruter
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.7.1
Component:  Customize                |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch commit fixed-  |     Focuses:  javascript,
  major                              |  administration
-------------------------------------+-------------------------------------
Changes (by westonruter):

 * keywords:  has-patch => has-patch commit fixed-major
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Re-opening for 4.7.1.

 @Christian1012 I realized we could just pass through `url` as-is as the
 third parameter instead of `null` so that's what I did in [39547]. That
 will allow `undefined`, `null`, and `false`, and `""` to all be passed
 through—all of which should have the same effect as just passing through
 `null`, but maybe an author in the future would have a reason to pass a
 non-string value into the function if the spec changes, however unlikely.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39175#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list