[wp-trac] [WordPress Trac] #39038: Add support for non-split shared terms to singular term capabilities

[WordPress Trac]

#39038: Add support for non-split shared terms to singular term capabilities
--------------------------+--------------------
 Reporter:  dd32          |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.7.1
Component:  Taxonomy      |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+--------------------
Changes (by boonebgorges):

 * keywords:   => needs-patch


Comment:

 I'm with @dd32 that we are probably far enough along that we can assume,
 throughout most of the taxonomy API, that terms have been split. Auth
 checks are a case where we should be extra careful, but we're erring on
 the side of caution here (shared terms will get 'do_not_allow').

 Something like [attachment:35614.diff] seems OK, but it could result in
 weird behavior due to latency or race conditions when the same cap-check
 happens more than once on a page: the first time it could fail, triggering
 a split, while on a subsequent call it might succeed. This could have
 consequences that are difficult to predict, though it'd only be a one-time
 occurrence for a given term, so maybe it's an OK consequence.

 (If we want to go this direction, the patch will need to be written in a
 way that fetches all terms sharing the term_id, so that we have a `tt_id`
 to pass to `_split_shared_term()`.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39038#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform