[wp-trac] [WordPress Trac] #38911: Prevent Media Library search making an AJAX request for each char typed.

WordPress Trac noreply at wordpress.org
Thu Dec 8 15:44:33 UTC 2016


#38911: Prevent Media Library search making an AJAX request for each char typed.
-------------------------+-------------------------------------------------
 Reporter:               |       Owner:  adamsilverstein
  brandomeniconi         |      Status:  assigned
     Type:  enhancement  |   Milestone:  Awaiting Review
 Priority:  normal       |     Version:  4.6.1
Component:  Media        |  Resolution:
 Severity:  normal       |     Focuses:  javascript, administration,
 Keywords:  has-patch    |  performance
-------------------------+-------------------------------------------------
Changes (by joemcgill):

 * keywords:  has-patch 2nd-opinion => has-patch


Comment:

 [attachment:38911.diff] Looks pretty good, though the debounce time of
 500ms feels a bit slow to me. I would target somewhere around 200-300ms
 for this interaction.

 Also, it looks like the `search` and `change` handlers were added by @koop
 in [22533] to "properly capture clearing the search box", but I'm not
 seeing any side affects when these are removed. @adamsilverstein were you
 seeing other side affects by leaving the extra handlers in?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38911#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list