[wp-trac] [WordPress Trac] #39175: Customizer assumes url is passed with replaceState and pushState
WordPress Trac
noreply at wordpress.org
Thu Dec 8 06:45:34 UTC 2016
#39175: Customizer assumes url is passed with replaceState and pushState
---------------------------+-----------------------------------------
Reporter: Christian1012 | Owner: westonruter
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 4.7.1
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript, administration
---------------------------+-----------------------------------------
Comment (by westonruter):
@Christian1012 given that the HTML spec says of `history.replaceState()`:
> Updates the current entry in the session history to have the given data,
title, and, if provided and not null, URL.
So if the URL is not being updated, should we not then also do this
behavior and only call `injectUrlWithState` if `! _.isUndefined( url ) &&
null !== url`? See [attachment:39175.2.diff].
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39175#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list