[wp-trac] [WordPress Trac] #39152: Twenty Seventeen: phpcs errors and warnings

WordPress Trac noreply at wordpress.org
Wed Dec 7 17:43:00 UTC 2016

#39152: Twenty Seventeen: phpcs errors and warnings
 Reporter:  dingo_bastard  |      Owner:
     Type:  enhancement    |     Status:  new
 Priority:  normal         |  Milestone:  Awaiting Review
Component:  Bundled Theme  |    Version:  4.7
 Severity:  normal         |   Keywords:
  Focuses:                 |
 Since we are aiming towards automation of the theme review, as described
 in this [[https://make.wordpress.org/themes/2016/09/29/why-are-we-working-
 to-improve-the-automation-of-the-theme-review/|blog post]] I wanted to
 check what's the status with the newly Twenty Seventeen theme.

 I used the WordPress coding standard (which also includes the VIP standard
 sniffs which we can ignore), and ignored the *.js and *.css files (errors
 there were mostly based about spacing and inline comments, which the phpcs
 pulled from php rules).

 I'm attaching the log file with the errors. Some can be easily fixed by
 running phpcbf, but some should be taken care of manually - for instance
 in the `content-video.php` file located in the \template-parts\post folder
 on line 67 there is

 echo $video_html;

 which should be escaped (I added `esc_html()` and the test videos provided
 in the theme unit test worked).

 Hope this helps :)

Ticket URL: <https://core.trac.wordpress.org/ticket/39152>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list