[wp-trac] [WordPress Trac] #37699: Death to Globals Episode #1: A Registry, A Pattern

WordPress Trac noreply at wordpress.org
Tue Dec 6 12:03:11 UTC 2016


#37699: Death to Globals Episode #1: A Registry, A Pattern
----------------------------+------------------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:
----------------------------+------------------------------

Comment (by bobbingwide):

 Replying to [comment:61 boonebgorges]:
 > [38398] broke BuddyPress's tests. BP had been setting up some initial
 data in WP `page` objects in each `setUpBeforeClass()`, and these objects
 are now wiped out. It's easily fixed, but worth noting, as there may be
 others relying on the current behavior. It'd be nice to document the
 change somewhere other than this ticket, whose relationship to [38398] is
 not clear. https://buddypress.trac.wordpress.org/ticket/7241

 Just to confirm that there were others relying on the current behaviour.
 While attempting to run my 'in situ' PHPUnit tests I managed to completely
 empty two development databases before discovering these changes.
 https://github.com/bobbingwide/wordpress-develop-tests/issues/2

 Some things are learnt the hard way.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37699#comment:111>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list