[wp-trac] [WordPress Trac] #39104: Customize: starter content home menu item needs to be a link, not a page

[WordPress Trac]

#39104: Customize: starter content home menu item needs to be a link, not a page
------------------------------+-------------------------
 Reporter:  celloexpressions  |      Owner:
     Type:  defect (bug)      |     Status:  new
 Priority:  normal            |  Milestone:  4.7.1
Component:  Customize         |    Version:  trunk
 Severity:  major             |   Keywords:  needs-patch
  Focuses:                    |
------------------------------+-------------------------
 Core menus use a custom link item for "home" rather than associating home
 with a static front page, when present. However, starter content provides
 a `page_home` item that insets the "home" page as an item in the starter
 menu.

 Menus use a link for "home" because the page item will not always actually
 link home if the user changes the static front page option to be a
 different page or show the latest posts. This also means that core does
 not provide a starter-content menu item for "home" for themes that default
 to showing latest posts on front. For these reasons, the `page_home` menu
 item in starter content should be ''replaced'' with `link_home` to avoid
 theme developers accidentally introducing this usability trap.

 Presuming that this is delayed to 4.7.1, we probably shouldn't remove the
 `page_home` item entirely. Instead we can deprecate it ''and'' change it
 to be the link-type menu item that it should be. We'd also add a
 `link_home` item that has a `title` of "Home" and a `url` of the site url.
 Because `page_home` becomes an unfortunate deprecated item existing only
 for back compat and with an inaccurate name, Twenty Seventeen would need
 to be updated alongside 4.7.1 as it currently contains the only canonical
 example implementation of starter content and is likely to be directly
 copied.

 '''Note that until this is changed, all users creating a new site with
 core starter content will end up with easily-broken "home" links in their
 menus.'''

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39104>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform