[wp-trac] [WordPress Trac] #39071: Pages created as theme starter content aren't saved if a page is created from Customizer

[WordPress Trac]

#39071: Pages created as theme starter content aren't saved if a page is created
from Customizer
-------------------------------------+--------------------------
 Reporter:  dlh                      |       Owner:  westonruter
     Type:  defect (bug)             |      Status:  accepted
 Priority:  high                     |   Milestone:  4.7
Component:  Customize                |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+--------------------------
Changes (by westonruter):

 * keywords:   => has-patch needs-testing
 * owner:   => westonruter
 * priority:  normal => high
 * status:  new => accepted
 * milestone:  Awaiting Review => 4.7


Comment:

 @dlh excellent catch! The problem is that when starter content is applied,
 the `nav_menus_created_posts` setting is initially non-empty.
 Nevertheless, the nav menus logic is expecting that it would be empty as
 seen in the `insertedAutoDrafts` array which would keep track of the
 newly-created nav menus in the current customizer session. Once saving, it
 was intended that this would be used to empty out the list but the logic
 is faulty. We should only be manipulating the one setting and not trying
 to keep a separate copy around.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39071#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform