[wp-trac] [WordPress Trac] #39035: Twenty Seventeen: Header media (images and video) appear zoomed in
WordPress Trac
noreply at wordpress.org
Sat Dec 3 20:20:31 UTC 2016
#39035: Twenty Seventeen: Header media (images and video) appear zoomed in
------------------------------+----------------------------
Reporter: laurelfulford | Owner: davidakennedy
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.7
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses:
------------------------------+----------------------------
Changes (by davidakennedy):
* keywords: has-patch => has-patch commit
Comment:
Thanks for the patches @laurelfulford and @peterwilsoncc!
Both of these patches do the job. But I like [attachment:39035.2.diff]
better, because as @joemcgill pointed out, it exposes theme developers to
a fairly new CSS feature with good browser support. It's also fixes a CSS
problem with just CSS, which is a cleaner solution to me. The browser
support is still solid for `@supports`, see: http://caniuse.com/#feat=css-
featurequeries
I tested in all the modern browsers, including Edge, IE 11, 10, 9 and 8. I
looked at both the front end and Customizer view and it looks good. I
think the feature queries patch is the way to go. And I agree we should
try to improve the zooming in future versions of the theme.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39035#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list