[wp-trac] [WordPress Trac] #21760: get_term_by() calls are not cached

[WordPress Trac]

#21760: get_term_by() calls are not cached
-------------------------------------------------+-------------------------
 Reporter:  wonderboymusic                       |       Owner:  ocean90
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.7
Component:  Taxonomy                             |     Version:  2.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests commit                                   |  performance
-------------------------------------------------+-------------------------
Changes (by barry):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:112 ocean90]:
 > @vnsavage Can you please open a new ticket? We can look into it but I'm
 not sure if we can do anything for this case. Note that this is already
 [https://github.com/Automattic/jetpack/pull/5784 fixed in Jetpack]. See
 also https://wordpress.slack.com/archives/core/p1480465372004559.

 I am not sure why there needs to be a new ticket.  This ticket is where
 the breaking change was committed so it seems best to keep all of the
 conversation in one place.

 I think at least the breaking change part of this commit needs to be
 reverted.   It not only affects every site running the latest release of
 Jetpack and a supported theme, but also at least the following themes from
 the .org theme repository:

 anderson-lite
 courage
 dynamic-news-lite
 glades
 momentous-lite
 rubine-lite
 smartline-lite

 Keep in mind that between auto-updates and host-provided WP core upgrades,
 lots of sites will be upgraded without user intervention when 4.7 is
 released.  If we knowingly break even a small % of those sites it will
 severely impact the trust we have built in our so far, pretty awesome,
 auto-upgrade track record.

 Also of note, this triggers a segmentation fault in some php
 configurations which could impact unrelated requests (if it's able to
 create memory corruption, etc).  Actual impact depends on the specific
 configuration, but it could be pretty bad.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21760#comment:113>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform