[wp-trac] [WordPress Trac] #39031: Customize: Include theme as just another setting instead of passing as separate parameter

WordPress Trac noreply at wordpress.org
Fri Dec 2 19:01:12 UTC 2016


#39031: Customize: Include theme as just another setting instead of passing as
separate parameter
-------------------------+-----------------------------
 Reporter:  westonruter  |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Future Release
Component:  Customize    |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:
-------------------------+-----------------------------
Description changed by westonruter:

Old description:

> The customizer state is currently split in two places: the `customized`
> settings (changeset) and the previewed `theme`. This separation of the
> theme from the settings makes sense to a degree since the settings are
> dependent upon which theme is active. There is currently an
> `active_theme` setting but it is a dummy setting which is used merely for
> the sake of wiring up the capability check for the themes panel. The
> `active_theme` setting is added with a comment:
>
> > unused - the theme is considerably more fundamental to the Customizer
> experience
>
> However, since the `theme` is not just another `setting` then this means
> that the theme cannot currently be made part of a changeset, and as such
> a theme switch cannot be previewed on the frontend by non-authenticated
> users and also a theme switch cannot be scheduled in the customizer.
> Ideally there could be a `theme` setting with the `switch_themes`
> capability that could be added to a changeset, and when that changeset is
> published, the `switch_theme` call should then be made.

New description:

 The customizer state is currently split in two places: the `customized`
 settings (changeset) and the previewed `theme`. This separation of the
 theme from the settings makes sense to a degree since the settings are
 dependent upon which theme is active. There is currently an `active_theme`
 setting but it is a dummy setting which is used merely for the sake of
 wiring up the capability check for the themes panel. The `active_theme`
 setting is added with a comment:

 > unused - the theme is considerably more fundamental to the Customizer
 experience

 However, since the `theme` is not just another `setting` then this means
 that the theme cannot currently be made part of a changeset, and as such a
 theme switch cannot be previewed on the frontend by non-authenticated
 users and also a theme switch cannot be scheduled in the customizer.
 Ideally there could be a `theme` setting with the `switch_themes`
 capability that could be added to a changeset, and when that changeset is
 published, the `switch_theme` call should then be made.

 See also #22880.

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39031#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list