[wp-trac] [WordPress Trac] #38993: Twenty Seventeen: Clearing header text color doesn't update color in preview

[WordPress Trac]

#38993: Twenty Seventeen: Clearing header text color doesn't update color in
preview
--------------------------------------------+--------------------
 Reporter:  ocean90                         |       Owner:
     Type:  defect (bug)                    |      Status:  new
 Priority:  low                             |   Milestone:  4.7
Component:  Bundled Theme                   |     Version:  trunk
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch needs-testing commit  |     Focuses:
--------------------------------------------+--------------------

Comment (by westonruter):

 @davidakennedy

 * What about the situation when the header text color is ''added''? This
 patch removes the `#twentyseventeen-custom-header-styles` stylesheet
 entirely. When the header text is ''added'' shouldn't the `style` element
 be restored?
 * Likewise, when `is_customize_preview()`, the
 `twentyseventeen_header_style()` should output an empty `style` element
 when short-circuiting, even when there are no styles. This is so that the
 the style can be restored.
 * The JS logic assumes that `default-text-color` is going to be an empty
 string. What if a child theme sets the default color?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38993#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform