[wp-trac] [WordPress Trac] #38992: Twenty Seventeen: Menu toggle doesn't work after adding a new menu item in customizer

[WordPress Trac]

#38992: Twenty Seventeen: Menu toggle doesn't work after adding a new menu item in
customizer
-------------------------------------------+----------------------------
 Reporter:  ocean90                        |       Owner:  davidakennedy
     Type:  defect (bug)                   |      Status:  closed
 Priority:  normal                         |   Milestone:  4.7
Component:  Bundled Theme                  |     Version:  trunk
 Severity:  normal                         |  Resolution:  fixed
 Keywords:  has-patch commit dev-reviewed  |     Focuses:  javascript
-------------------------------------------+----------------------------
Changes (by davidakennedy):

 * owner:   => davidakennedy
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"39419"]:
 {{{
 #!CommitTicketReference repository="" revision="39419"
 Twenty Seventeen: Fix broken menu toggle in Customizer after menu items
 are added

 This simplifies the line `$( siteNavigation.closest( '.main-navigation' ),
 this ).toggleClass( 'toggled-on' );` to `$( siteNavContain ).toggleClass(
 'toggled-on' );`, since `this` is the clicked button, so the extra context
 isn't needed.

 Props afercia, laurelfulford.

 Fixes #38992.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38992#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform