[wp-trac] [WordPress Trac] #38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.

[WordPress Trac]

#38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.
-------------------------------------------+------------------------
 Reporter:  joemcgill                      |       Owner:  joemcgill
     Type:  defect (bug)                   |      Status:  closed
 Priority:  normal                         |   Milestone:  4.7
Component:  Bundled Theme                  |     Version:  trunk
 Severity:  normal                         |  Resolution:  fixed
 Keywords:  has-patch commit dev-reviewed  |     Focuses:
-------------------------------------------+------------------------

Comment (by laurelfulford):

 Playing around with this a bit more, I noticed a change from
 [attachment:38995.2.patch] to custom-header.php was lost in the back and
 forth.

 The styles for the header text colour need to have versions with the
 `.has-header-video` class explicitly set in front of them, like:

 {{{
 .site-title a,
 .colors-dark .site-title a,
 .colors-custom .site-title a,
 body.has-header-image .site-title a,
 body.has-header-video .site-title a,
 body.has-header-image.colors-dark .site-title a,
 body.has-header-video.colors-dark .site-title a,
 body.has-header-image.colors-custom .site-title a,
 body.has-header-video.colors-custom .site-title a,
 .site-description,
 .colors-dark .site-description,
 .colors-custom .site-description,
 body.has-header-image .site-description,
 body.has-header-video .site-description,
 body.has-header-image.colors-dark .site-description,
 body.has-header-video.colors-dark .site-description,
 body.has-header-image.colors-custom .site-description,
 body.has-header-video.colors-custom .site-description {
         color: #<?php echo esc_attr( $header_text_color ); ?>;
 }
 }}}

 I can attach a patch that includes this shortly. I'm sorry I didn't spot
 this sooner!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38995#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform