[wp-trac] [WordPress Trac] #38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.

[WordPress Trac]

#38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.
-------------------------------------------+------------------------
 Reporter:  joemcgill                      |       Owner:  joemcgill
     Type:  defect (bug)                   |      Status:  closed
 Priority:  normal                         |   Milestone:  4.7
Component:  Bundled Theme                  |     Version:  trunk
 Severity:  normal                         |  Resolution:  fixed
 Keywords:  has-patch commit dev-reviewed  |     Focuses:
-------------------------------------------+------------------------
Changes (by joemcgill):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"39413"]:
 {{{
 #!CommitTicketReference repository="" revision="39413"
 Twenty Seventeen: Better handling of custom headers when no image is set.

 This ensures that a standard header is shown on the front page whenever
 a header video is set without a header image if the video doesn't load,
 e.g., on mobile sizes or if the JS doesn't fire.

 This adds a new class, `.has-header-video` that is added whenever the
 `wp-custom-header-video-loaded` event is fired, which is then used to
 style
 the custom headers along with `.has-header-image` whenever a header image
 is available. This also changes the class name on the custom header media
 wrapping `div` from `.custom-header-image` to `.custom-header-media`.

 Props laurelfulford, joemcgill.
 Fixes #38995.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38995#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform