[wp-trac] [WordPress Trac] #38025: Query networks with meta_query
WordPress Trac
noreply at wordpress.org
Thu Dec 1 19:48:32 UTC 2016
#38025: Query networks with meta_query
-------------------------------------+------------------------------
Reporter: johnjamesjacoby | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Networks and Sites | Version: 4.6
Severity: normal | Resolution:
Keywords: needs-patch 2nd-opinion | Focuses: multisite
-------------------------------------+------------------------------
Comment (by spacedmonkey):
I little back story on this one for anyone new to the ticket. @flixos90 's
orignal patch did have the meta query in it, but pretty late in the
ticket, I asked for it to be removed. There were issues with cache
invalidation when you changed the network option. It meant for example,
you changed site 2 network option "name" from test to example, the query
with a meta query, will still return site 2 for a meta query for "test".
It was removed in hopes to put it back in later.
My personal view is the network options (that are formatted as site
network meta in the db) should be treated like other object types meta. I
have a ticket #37181 open to change in the internals of the
*_network_options functions to use the metadata api. I know this is a big
change, but opens a lot of doors in the future. Until we decide what is
happening with how network options are thought of in core, this ticket
will not progress.
I believe that @flixos90 & @johnjamesjacoby and myself have made our
feelings clear about making network option more like meta. But I know that
@jeremyfelt had his issues with the idea. Would like if we worked on this
ticket in 4.8
Related: #37181
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38025#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list