[wp-trac] [WordPress Trac] #38993: Twenty Seventeen: Clearing header text color doesn't update color in preview

[WordPress Trac]

#38993: Twenty Seventeen: Clearing header text color doesn't update color in
preview
-------------------------------------+--------------------
 Reporter:  ocean90                  |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  low                      |   Milestone:  4.7
Component:  Bundled Theme            |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+--------------------
Changes (by sstoqnov):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 As @ocean90 mentioned in Slack discussion, the color doesn't remove
 because the styles are still in header.
 Since we are not able to remove that styles I made a check if there is a
 color, and if not revert to original colors.
 I am not sure that this is the best way to add the text color, when there
 is custom header image.

 And I think that there is another problem with color picker.

 * Go to the customizer and the colors section
 * Choose a color
 * Click "Save & Publish"
 * Reload customizer (CMD/CTRL+R)
 * Go to the customizer and the colors section
 * Click the "Clear" button
 * Refresh the page without saving
 * The text colors are back to default

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38993#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform