[wp-trac] [WordPress Trac] #38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.

[WordPress Trac]

#38995: Twenty Seventeen: Custom headers incorrect on mobile when no image is set.
---------------------------+------------------------
 Reporter:  joemcgill      |       Owner:  joemcgill
     Type:  defect (bug)   |      Status:  accepted
 Priority:  normal         |   Milestone:  4.7
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------
Changes (by laurelfulford):

 * keywords:  needs-patch => has-patch


Comment:

 [attachment:38995.patch]  adds a class `.header-video-loaded` via
 JavaScript when `wp-custom-header-video-loaded` is fired; this makes sure
 it's only added when the video is visible.

 `.has-header-image` has been updated so it's only added when a header
 image is uploaded, and the styles have been updated to reflect these
 changes.

 I'd love to get some thoughts on another potential change to this section:
 in the theme we have the file template-parts/header-image.php, and in it
 the class `.custom-header-image`, which is on a `div` that holds both the
 header image and video. Both are left over from before video header
 support was added, and have been bugging me since they're no longer
 accurate.

 Would it be beneficial to update these to 'header-media.php' and `.custom-
 header-media` to prevent confusion? Or better to leave as is at this
 stage?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38995#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform