[wp-trac] [WordPress Trac] #37696: WP_Comment_Query loses sql_clauses with Object Cache

[WordPress Trac]

#37696: WP_Comment_Query loses sql_clauses with Object Cache
--------------------------+---------------------------
 Reporter:  Rarst         |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.6.1
Component:  Comments      |     Version:  4.6
 Severity:  normal        |  Resolution:
 Keywords:  fixed-major   |     Focuses:
--------------------------+---------------------------

Comment (by jeremyfelt):

 I stared at the code around this for a while and the approach looks
 correct/sane. +1

 To log the obvious - The previous manual SQL statement uses `SELECT
 wp_comments.comment_ID, wp_comments.comment_parent`. The current
 `get_comments()` approach generates `SELECT wp_comments.comment_ID`. This
 is okay because the comment parent is instead available in the retrieved
 comment object.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37696#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform