[wp-trac] [WordPress Trac] #37898: Prompt message when removing a plugin is sometimes misleading

[WordPress Trac]

#37898: Prompt message when removing a plugin is sometimes misleading
--------------------------+-----------------------------
 Reporter:  bradt         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Plugins       |    Version:  trunk
 Severity:  normal        |   Keywords:
  Focuses:  ui            |
--------------------------+-----------------------------
 When you attempt to delete a plugin in 4.6, a JS prompt asks "Are you sure
 you want to delete <plugin name> and its data?" regardless whether or not
 there's an uninstall.php in the plugin that will actually delete plugin
 data.

 This is misleading users as many plugins do not include uninstall.php
 files and do leave behind data.

 Plugin authors also intentionally leave an uninstall.php out of their
 plugin and don't remove data to ensure users don't accidentally delete
 their data when upgrading a plugin via a "delete - upload new zip"
 process. This message will be confusing to those users who are trying to
 upgrade using this process without losing data.

 [https://github.com/WordPress/WordPress/blob/4.5.3/wp-
 admin/plugins.php#L306 The plugin delete prompt prior to 4.6] would detect
 whether an uninstall.php file exists in the plugin and only change the
 messaging to say that data would be deleted if the uninstall.php existed.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37898>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform