[wp-trac] [WordPress Trac] #37846: Minor Parent Menu Item Deletion 'sub item' Issue

WordPress Trac noreply at wordpress.org
Wed Aug 31 16:02:29 UTC 2016


#37846: Minor Parent Menu Item Deletion 'sub item' Issue
--------------------------+---------------------------------------------
 Reporter:  rnoakes3rd    |       Owner:  adamsilverstein
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.7
Component:  Menus         |     Version:
 Severity:  trivial       |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui, javascript, administration
--------------------------+---------------------------------------------
Changes (by adamsilverstein):

 * owner:   => adamsilverstein
 * status:  new => assigned


Comment:

 @rnoakes3rd Thanks for the patch, works great!

 I tested this and verified it fixes the issue you noted.

 Here is a screencast as a visual record:

 * before the patch:
 https://cl.ly/0X3R1e1M3z32/screencast_2016-08-31_11-46-05.mp4
 * after the patch:
 https://cl.ly/3T1g0e2M3y0y/screencast_2016-08-31_11-48-57.mp4

 I also tested the patch with multiple level menus and everything worked as
 expected.

 ps. Please note that for consistency we generate patches one folder up
 from where you where, the trunk folder of the WordPress development
 repository. I am uploading an updated patch. I also added a bit more
 whitespace inside parentheses (only for the code we are touching and
 despite the nearby non spaced code), following the
 [https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/javascript/#examples-of-good-spacing WordPress JavaScript coding
 standards].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37846#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list