[wp-trac] [WordPress Trac] #37416: In WP_Comment_Query::fill_descendants() compute the size beforehand and not on each iteration

[WordPress Trac]

#37416: In WP_Comment_Query::fill_descendants() compute the size beforehand and not
on each iteration
-------------------------------------------------+-------------------------
 Reporter:  ocean90                              |       Owner:
     Type:  defect (bug)                         |  wonderboymusic
 Priority:  low                                  |      Status:  reopened
Component:  Comments                             |   Milestone:  4.7
 Severity:  normal                               |     Version:  4.4
 Keywords:  good-first-bug has-patch needs-      |  Resolution:
  testing                                        |     Focuses:
                                                 |  performance
-------------------------------------------------+-------------------------
Changes (by ocean90):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 @nacin See https://travis-
 ci.org/aaronjorbin/develop.wordpress/jobs/153889644#L380.

 [38298] isn't needed if the condition in [38297] wasn't changed from `<`
 to `<=`. Was there a reason for that? I don't think so since the index
 starts at 0.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37416#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform