[wp-trac] [WordPress Trac] #37416: In WP_Comment_Query::fill_descendants() compute the size beforehand and not on each iteration

[WordPress Trac]

#37416: In WP_Comment_Query::fill_descendants() compute the size beforehand and not
on each iteration
-------------------------------------------------+-------------------------
 Reporter:  ocean90                              |       Owner:
     Type:  defect (bug)                         |  wonderboymusic
 Priority:  low                                  |      Status:  closed
Component:  Comments                             |   Milestone:  4.7
 Severity:  normal                               |     Version:  4.4
 Keywords:  good-first-bug has-patch needs-      |  Resolution:  fixed
  testing                                        |     Focuses:
                                                 |  performance
-------------------------------------------------+-------------------------

Comment (by nacin):

 Replying to [comment:3 wonderboymusic]:
 > In [changeset:"38298"]:
 > {{{
 > #!CommitTicketReference repository="" revision="38298"
 > Comments: in `WP_Comment_Query::fill_descendants()`, `continue` if there
 is an empty array in the loop.
 >
 > See #37416, [38297].
 > }}}

 @wonderboymusic, was this necessary after [38297]? Or is this just another
 optimization on top of that?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37416#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform